Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for VTE's notification-received patch #984

Closed
egmontkob opened this issue Jan 15, 2025 · 0 comments · Fixed by #986
Closed

Fix the check for VTE's notification-received patch #984

egmontkob opened this issue Jan 15, 2025 · 0 comments · Fixed by #986

Comments

@egmontkob
Copy link
Contributor

See https://gitlab.gnome.org/GNOME/vte/-/issues/2858 for details. Quick summary:

The investigator of the crash said

Ah, but terminator appears to be deliberately using this code as a feature test. [...] if the signal fails to connect, it falls back to assuming that that vte patch is unavailable. It's just that it doesn't cope if vte actually crashes.

To which VTE's main developer responded

Creating an instance and connecting to a signal to check if it exist isn't the right way to do this. The right way is to use g_signal_lookup with the name and gtype.

Although VTE was patched not to crash anymore, it would be nice if Terminator switched to the proper way of testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant