Clean up VTE notification-received signal check #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prompts a crash with some versions of VTE and Python (see https://gitlab.gnome.org/GNOME/vte/-/issues/2858), and although the crash has been fixed in VTE, VTE's main developer said that creating an instance and connecting to a signal isn't the right way to do this check. Use the test they recommend instead. Fixes: gnome-terminator#984
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prompts a crash with some versions of VTE and Python (see https://gitlab.gnome.org/GNOME/vte/-/issues/2858), and although the crash has been fixed in VTE, VTE's main developer said that creating an instance and connecting to a signal isn't the right way to do this check. Use the test they recommend instead.
Fixes: #984