Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition when calling grab_focus after underlying vte could be closed #388

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Fixed race condition when calling grab_focus after underlying vte could be closed #388

merged 1 commit into from
Feb 20, 2021

Conversation

TheBigS
Copy link
Contributor

@TheBigS TheBigS commented Feb 19, 2021

I found a race condition where the command I specified for the new vte had already exited by the time grab_focus was called. This caused the terminal to start cleaning up and the self.vte was None by the time grab_focus executed.

This caused a Could not call method 'has_focus()' on NoneType error. Not a huge deal because the terminal closed itself anyway. Easy fix to avoid the error by adding the None check before the has_focus call.

@mattrose
Copy link
Member

Thanks for this

@mattrose mattrose merged commit 23a15ea into gnome-terminator:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants