Fixed race condition when calling grab_focus after underlying vte could be closed #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a race condition where the command I specified for the new vte had already exited by the time
grab_focus
was called. This caused the terminal to start cleaning up and theself.vte
wasNone
by the timegrab_focus
executed.This caused a
Could not call method 'has_focus()' on NoneType
error. Not a huge deal because the terminal closed itself anyway. Easy fix to avoid the error by adding the None check before thehas_focus
call.