805 keyboard shortcut support for plugins code decoupling #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2) plugin_util file to assist this and other plugins with key-press Helper function 3) adding Key Binding Help Functions in above (2) to config and preferences->keybinding to have a consistent behavior
…eyboard-URL-Open gnome-terminator#681 Merge remote-tracking branch 'upstream/master' into 450-mouseless-URL-opening-or-yanking 1) Mouse less/free opening / yanking feature 2) plugin_util file to assist this and other plugins with key-press Helper function 3) adding Key Binding Help Functions in above (2) to config and preferences->keybinding to have a consistent behavior
…inding Feature: Mouseless / Mousefree / Keyboard URL opening or yanking gnome-terminator#681 - there was a bug wherein the duplicate keybindings from plugins were not throwing the error "Duplicate Key Bindings Are Not Allowed", now while checking they are merged and then final list of keybindings are checked.
…inding Feature: Mouseless / Mousefree / Keyboard URL opening or yanking gnome-terminator#681 -convert control keys keyval to standard lowercase, else signals are missing
…Binding Feature: Mouseless / Mousefree / Keyboard URL opening or yanking gnome-terminator#681 - removed plugin_util - added key unbind feature - updated plugin helper - updated plugin helper - to have config as part of constructor - updated MouseFreeURLHandler for plugin.py, unload - removed circular dependency between plugin.py and config.py due to KeyBindUtil due to merging of plugin_util.py
…inding Feature: Mouseless / Mousefree / Keyboard URL opening or yanking gnome-terminator#681 - renamed api interfacted for better clarity - removed double checking of short-cut binding for plugins in keybindings
…sion-Plugin-Utility-KeyBinding-Mouseless-Keyboard-URL-Open
This was referenced Aug 8, 2023
Closed
|
This looks good! Thanks again, and sorry about the wait. |
|
@mattrose thanks for looking into this may be once back I should add documentation for key bind utility :) yes ‘documentation’ :) cheers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.