Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use text templates for formatting issues #98

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

0xtekgrinder
Copy link
Contributor

fixes #75

This PR refactor how the formatter works to use text/template go package.

This replicates so far how the old formatter is working

Copy link
Contributor

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the touch this issue. I think it will be easy to apply a consistent format when outputting the lint results.

However, currently, after building and running, when printing the problematic code lines, they are not displayed across multiple lines but are shown on a single line. Could you please check this? thank you

@0xtekgrinder 0xtekgrinder force-pushed the refactor/use-text-templates branch from cde9425 to 24bd678 Compare October 30, 2024 12:32
@0xtekgrinder 0xtekgrinder requested a review from notJoon October 30, 2024 13:13
Copy link
Contributor

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notJoon notJoon merged commit dba079d into gnoverse:main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Template for Formatting the Issues
2 participants