Fix data race in executor with enabling the limit mode #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause is we write the limitModeFuncsRunning(a wait group) in the new goroutine, so the Go data race detector will think them have the data race due to reading and writing in different routines.
JohnRoesler
approved these changes
May 7, 2023
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
The root cause is we write the limitModeFuncsRunning(a wait group) in the new goroutine, so the Go data race detector will think they have the data race due to reading and writing in different routines.
I'm sorry for didn't run tests in data race mode in the previous PR. @JohnRoesler
Which issue(s) does this PR fix/relate to?
Fix the data race in https://github.com/go-co-op/gocron/actions/runs/4905158223/jobs/8758756592
List any changes that modify/break current functionality
None
Have you included tests for your changes?
None
Did you document any new/modified functionality?
example_test.goREADME.mdNotes