refact: rewriting scheduler logic #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streppel
commented
Aug 29, 2020
| @@ -306,23 +365,6 @@ func (s *Scheduler) Do(jobFun interface{}, params ...interface{}) (*Job, error) | |||
| } | |||
| } | |||
|
|
|||
| if !j.startsImmediately { | |||
|
|
|||
| if j.lastRun == s.time.Unix(0, 0) { | |||
There was a problem hiding this comment.
this was a workaround that had impact on the job scheduling logic and got removed
JohnRoesler
reviewed
Aug 31, 2020
JohnRoesler
reviewed
Aug 31, 2020
JohnRoesler
reviewed
Aug 31, 2020
Co-authored-by: John Roesler <[email protected]>
arjunmahishi
reviewed
Sep 1, 2020
…x/weekdays_scheduling
|
@arjunmahishi @JohnRoesler cleaned up tests and fixed monthly issues, good to go now :-) there are tests missing (startImmediately reschedule etc) but we didn't have a strong test suite for these before anyway, so what do you think about leaving these tests for a future PR? Our schedule method is now much more assertive, intelligent and readable IMO. Download the branch and let me know what you think. |
JohnRoesler
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Time scheduling was spread between job registration and actual schedule calculation, which was confusing and made testing difficult. As a matter of fact, our weekdays logic wasn't working for some edge cases and we probably had some bugs out on .Month() calculation too, although I didn't check it explicitly.
This PR rewrites our next-run scheduling logic and cover it with different tests use cases, taking in consideration weekday schedules, weekdays schedules starting immediately and exact-time schedules.
Sorry for it being big. Most of the new lines are tests cases.
Which issue(s) does this PR fix/relate to?
This might fix #52. I cannot actually say this fixes it since I was not able to reproduce it, but nevertheless this PR fixes weekday logic.
List any changes that modify/break current functionality
None
Have you included tests for your changes?
Lots of, but might have missed something. Please bring it up if you can think of anything.