Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various smaller JSON-fixes #14

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Various smaller JSON-fixes #14

merged 3 commits into from
Sep 22, 2023

Conversation

GLundh
Copy link
Contributor

@GLundh GLundh commented Sep 13, 2023

  • Percentage summary for json
  • Refactored printBreakdown() to take json parameter
  • Add color to json output (usable when consumed by
    other tools).

@GLundh
Various smaller JSON-fixes
08b604a 
* Percentage summary for json
* Refactored printBreakdown() to take json parameter
* Add color to json output (usable when consumed by
  other tools).
@GLundh
Add language type to json percentage report
228998e
@GLundh
Fixes for type conversion
5aa9948
@GLundh
Copy link
Contributor Author

GLundh commented Sep 18, 2023

@bzz & @mcuadros ?

@bzz
Copy link
Member

bzz commented Sep 19, 2023

@GLundh thank you for sharing the improvements! Let me take a quick look and get back to you.

bzz
bzz approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@bzz bzz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Looks great to me.
Makes me think that we probably should make CI test profile to build and run the CLI binary, reporting json stats on the checkout 🤔

Merging if there is no further discussion.

@bzz bzz merged commit f107114 into go-enry:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzz bzz bzz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GLundh @bzz