fix: handling of control characters

go-faster · Jan 16, 2022 · c048666 · c048666
1 parent 298cc62
commit c048666
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/dec_skip_cases_test.go b/dec_skip_cases_test.go
@@ -12,7 +12,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-var testStrings = []string{
+var testStrings = append([]string{
 	`""`,                   // valid
 	`"hello"`,              // valid
 	`"`,                    // invalid
@@ -58,7 +58,13 @@ var testStrings = []string{
 	"\"\\ueeee\"",          // valid
 	"\"\\uFFFF\"",          // valid
 	`"ab\n` + "\x00" + `"`, // invalid
-}
+}, func() (r []string) {
+	// Generate tests for invalid space sequences.
+	for i := byte(0); i <= ' '; i++ {
+		r = append(r, `"`+string(i)+`"`)
+	}
+	return r
+}()...)
 
 var testObjs = []string{
 	"",                              // invalid

diff --git a/w_str.go b/w_str.go
@@ -213,7 +213,7 @@ var safeSet = [256]byte{
 	1, 1, 1, 1, 1, 1, 1, 1,
 	1, 1, 1, 1, 1, 1, 1, 1,
 	1, 1, 1, 1, 1, 1, 1, 1,
-	1, 1, 1, 1, 1, 1, 1,
+	1, 1, 1, 1, 1, 1, 1, 1,
 	'"':  1,
 	'\\': 1,
 }