feat(dec): skip capture if callback is nil

go-faster · Oct 31, 2021 · f185a66 · f185a66
1 parent 030f4cc
commit f185a66
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/dec_capture.go b/dec_capture.go
@@ -11,6 +11,9 @@ func (d *Decoder) Capture(f func(i *Decoder) error) error {
 	if d.reader != nil {
 		return xerrors.New("capture is not supported with reader")
 	}
+	if f == nil {
+		return nil
+	}
 	head, tail, depth := d.head, d.tail, d.depth
 	err := f(d)
 	d.head, d.tail, d.depth = head, tail, depth

diff --git a/dec_capture_test.go b/dec_capture_test.go
@@ -1,6 +1,7 @@
 package jx
 
 import (
+	"bytes"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -95,4 +96,13 @@ func TestDecoder_Capture(t *testing.T) {
 	}
 	require.Equal(t, Array, i.Next())
 	require.Equal(t, 3, elems)
+	t.Run("Nil", func(t *testing.T) {
+		require.NoError(t, i.Capture(nil))
+		require.Equal(t, Array, i.Next())
+	})
+}
+
+func TestDecoder_Capture_reader(t *testing.T) {
+	i := Decode(new(bytes.Buffer), 0)
+	require.Error(t, i.Capture(nil))
 }