test(tempoe2e): add autocomplete query test

go-faster · Jun 14, 2024 · 3fb15ba · 3fb15ba
1 parent 2dde5ad
commit 3fb15ba
Showing 1 changed file with 41 additions and 1 deletion.
diff --git a/integration/tempoe2e/common_test.go b/integration/tempoe2e/common_test.go
@@ -58,7 +58,9 @@ func setupDB(
 	if engineQuerier != nil {
 		engine = traceqlengine.NewEngine(engineQuerier, traceqlengine.Options{})
 	}
-	api := tempohandler.NewTempoAPI(querier, engine, tempohandler.TempoAPIOptions{})
+	api := tempohandler.NewTempoAPI(querier, engine, tempohandler.TempoAPIOptions{
+		EnableAutocompleteQuery: true,
+	})
 	tempoh, err := tempoapi.NewServer(api)
 	require.NoError(t, err)
 
@@ -351,6 +353,18 @@ func runTest(
 				maps.Keys(set.SpanNames),
 				false,
 			},
+			{
+				"SpanNameWithQuery",
+				tempoapi.SearchTagValuesV2Params{
+					AttributeSelector: `name`,
+					Start:             start,
+					End:               end,
+					Q:                 tempoapi.NewOptString(`{ name = "authenticate" && .service.name = }`),
+				},
+				"string",
+				[]string{"authenticate"},
+				false,
+			},
 			{
 				"SpanStatus",
 				tempoapi.SearchTagValuesV2Params{
@@ -406,6 +420,32 @@ func runTest(
 				maps.Keys(set.RootSpanNames),
 				false,
 			},
+			{
+				"RootSpanNameWithQuery",
+				tempoapi.SearchTagValuesV2Params{
+					AttributeSelector: `rootName`,
+					Start:             start,
+					End:               end,
+					Q:                 tempoapi.NewOptString(`{ name = "list-articles" }`),
+				},
+				"string",
+				[]string{"list-articles"},
+				false,
+			},
+			{
+				// Ensure that `rootName` would return nothing if we query a
+				// non-root span.
+				"RootSpanNameNoMatch",
+				tempoapi.SearchTagValuesV2Params{
+					AttributeSelector: `rootName`,
+					Start:             start,
+					End:               end,
+					Q:                 tempoapi.NewOptString(`{ name = "authenticate" }`),
+				},
+				"string",
+				nil,
+				false,
+			},
 			{
 				"RootServiceName",
 				tempoapi.SearchTagValuesV2Params{