fix(chstorage): sort metric labels and label values before returning

go-faster · Jun 11, 2024 · 9f3598e · 9f3598e
1 parent d214c03
commit 9f3598e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/chstorage/querier_metrics.go b/internal/chstorage/querier_metrics.go
@@ -177,6 +177,7 @@ func (p *promQuerier) getLabelValues(ctx context.Context, labelName string, matc
 		}
 		query.Where(expr)
 	}
+	query.Order(chsql.Ident(valueColumn), chsql.Asc)
 
 	if err := p.do(ctx, selectQuery{
 		Query: query,
@@ -384,7 +385,8 @@ func (p *promQuerier) getLabelNames(ctx context.Context) (result []string, rerr
 	var (
 		value = new(proto.ColStr).LowCardinality()
 		query = chsql.Select(table, chsql.Column("name_normalized", value)).
-			Distinct(true)
+			Distinct(true).
+			Order(chsql.Ident("name_normalized"), chsql.Asc)
 	)
 	if err := p.do(ctx, selectQuery{
 		Query: query,