Skip to content

Commit

Permalink
fix(chstorage): do not return high cardinality labels as part of series
Browse files Browse the repository at this point in the history
```
                            │     base      │                 new                  │
                            │    sec/op     │    sec/op     vs base                │
PromQL/All_POST_series        781.35m ±  4%   82.00m ± 11%  -89.51% (p=0.000 n=15)

                            │     base      │                 new                  │
                            │   ch-sec/op   │  ch-sec/op    vs base                │
PromQL/All_POST_series        206.69m ±  5%   78.95m ± 11%  -61.80% (p=0.000 n=15)

                            │      base       │                   new                   │
                            │ ch-mem-bytes/op │ ch-mem-bytes/op  vs base                │
PromQL/All_POST_series           68.47Mi ± 7%      38.76Mi ± 0%  -43.39% (p=0.000 n=15)

                            │       base       │                   new                    │
                            │ ch-read-bytes/op │ ch-read-bytes/op  vs base                │
PromQL/All_POST_series           32.543Mi ± 0%       1.431Mi ± 0%  -95.60% (p=0.000 n=15)

                            │      base       │                    new                    │
                            │ ch-read-rows/op │ ch-read-rows/op  vs base                  │
PromQL/All_POST_series            100.0k ± 0%       100.0k ± 0%        ~ (p=1.000 n=15) ¹
```
  • Loading branch information
tdakkota committed Jun 21, 2024
1 parent bbbb547 commit d77b43b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions internal/chstorage/querier_logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,7 @@ func (q *Querier) Series(ctx context.Context, opts logstorage.SeriesOptions) (re
{
var (
materialized = []string{
logstorage.LabelTraceID,
logstorage.LabelSpanID,
logstorage.LabelSeverity,
logstorage.LabelBody,
logstorage.LabelServiceName,
logstorage.LabelServiceInstanceID,
logstorage.LabelServiceNamespace,
Expand Down

0 comments on commit d77b43b

Please sign in to comment.