fix(otelbench): disallow positional arguments to avoid confusion

go-faster · Jun 18, 2024 · d912283 · d912283
1 parent d4ba238
commit d912283
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/cmd/otelbench/promql_analyze.go b/cmd/otelbench/promql_analyze.go
@@ -168,6 +168,7 @@ func newPromQLAnalyzeCommand() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "analyze",
 		Short: "Run promql queries",
+		Args:  cobra.NoArgs,
 		RunE: func(*cobra.Command, []string) error {
 			return p.Run()
 		},

diff --git a/cmd/otelbench/promql_bench.go b/cmd/otelbench/promql_bench.go
@@ -717,6 +717,7 @@ func newPromQLBenchmarkCommand() *cobra.Command {
 		Use:     "bench",
 		Aliases: []string{"benchmark"},
 		Short:   "Run promql queries",
+		Args:    cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
 			if err := p.Setup(cmd); err != nil {

diff --git a/cmd/otelbench/promrw_record.go b/cmd/otelbench/promrw_record.go
@@ -177,8 +177,8 @@ func newRecordCommand() *cobra.Command {
 	var recorder Record
 	cmd := &cobra.Command{
 		Use:   "record",
-		Args:  cobra.NoArgs,
 		Short: "Listen for remote write requests and record them to file",
+		Args:  cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			return recorder.Run(cmd.Context())
 		},