name createElementFromAttrs

go-gitea · Jun 26, 2024 · 7150181 · 7150181
1 parent d957c1c
commit 7150181
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/web_src/js/features/dropzone.js b/web_src/js/features/dropzone.js
@@ -4,7 +4,7 @@ import {clippie} from 'clippie';
 import {showTemporaryTooltip} from '../modules/tippy.js';
 import {GET, POST} from '../modules/fetch.js';
 import {showErrorToast} from '../modules/toast.js';
-import {createElementFromHTML, createElement, elemGetAttributeNumber} from '../utils/dom.js';
+import {createElementFromHTML, createElementFromAttrs, elemGetAttributeNumber} from '../utils/dom.js';
 
 const {csrfToken, i18n} = window.config;
 
@@ -69,7 +69,7 @@ export async function initDropzone(dropzoneEl) {
   dzInst.on('success', (file, data) => {
     file.uuid = data.uuid;
     fileUuidDict[file.uuid] = {submitted: false};
-    const input = createElement('input', {name: 'files', type: 'hidden', id: `dropzone-file-${data.uuid}`, value: data.uuid});
+    const input = createElementFromAttrs('input', {name: 'files', type: 'hidden', id: `dropzone-file-${data.uuid}`, value: data.uuid});
     dropzoneEl.querySelector('.files').append(input);
     addCopyLink(file);
   });
@@ -107,7 +107,7 @@ export async function initDropzone(dropzoneEl) {
         dzInst.emit('complete', attachment);
         addCopyLink(attachment);
         fileUuidDict[attachment.uuid] = {submitted: true};
-        const input = createElement('input', {name: 'files', type: 'hidden', id: `dropzone-file-${attachment.uuid}`, value: attachment.uuid});
+        const input = createElementFromAttrs('input', {name: 'files', type: 'hidden', id: `dropzone-file-${attachment.uuid}`, value: attachment.uuid});
         dropzoneEl.querySelector('.files').append(input);
       }
       if (!dropzoneEl.querySelector('.dz-preview')) {

diff --git a/web_src/js/utils/dom.js b/web_src/js/utils/dom.js
@@ -305,7 +305,7 @@ export function createElementFromHTML(htmlString) {
   return div.firstChild;
 }
 
-export function createElement(tagName, attrs) {
+export function createElementFromAttrs(tagName, attrs) {
   const el = document.createElement(tagName);
   for (const [key, value] of Object.entries(attrs)) {
     if (value === undefined || value === null) continue;

diff --git a/web_src/js/utils/dom.test.js b/web_src/js/utils/dom.test.js
@@ -1,11 +1,11 @@
-import {createElement, createElementFromHTML, elemGetAttributeNumber} from './dom.js';
+import {createElementFromAttrs, createElementFromHTML, elemGetAttributeNumber} from './dom.js';
 
 test('createElementFromHTML', () => {
   expect(createElementFromHTML('<a>foo<span>bar</span></a>').outerHTML).toEqual('<a>foo<span>bar</span></a>');
 });
 
-test('createElement', () => {
-  const el = createElement('button', {
+test('createElementFromAttrs', () => {
+  const el = createElementFromAttrs('button', {
     id: 'the-id',
     class: 'cls-1 cls-2',
     'data-foo': 'the-data',