-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heatmap: untranslated string: xx total contributions in the last 12 months #10669
Comments
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
ping ... |
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
it is still a issue |
The code was refactored into gitea/web_src/js/components/ActivityHeatmap.vue Lines 3 to 5 in d9b50e4
|
Given julienr114/vue-calendar-heatmap#19 it might be worth looking for alternatives (once Vue 3 migration is to start). gitea/web_src/js/components/ActivityHeatmap.vue Lines 8 to 9 in d9b50e4
reference gitea/web_src/js/components/ActivityHeatmap.vue Lines 39 to 42 in d9b50e4
and wouldn't be translated either. A fork exists as TypeScript project at https://www.npmjs.com/package/vue3-calendar-heatmap |
We still stayed in Vue2 currently. |
I have a feeling that there might not be too many blockers for upgrading to Vue3. And since the usage of Vue2 in Gitea is still at an early stage, if enough people agree, we should try to upgrade to Vue3. |
I'm migrating another project to Vue 3 currently. My learnings from there:
Can we reference this issue in a new issue about Vue 3? |
The calculation of the total sum is moved to the backend so a full HTML string could be sent. ![image](https://user-images.githubusercontent.com/20454870/232112381-c11d896b-ba47-40f8-b2a3-71cf4b3208de.png) - Closes #10669 - 2nd attempt (the first was in #21570) --------- Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: Giteabot <[email protected]>
Description
The string in the heatmap is not translated:
xx total contributions in the last 12 months
gitea/web_src/js/features/userHeatmap.js
Line 82 in 062f351
The text was updated successfully, but these errors were encountered: