Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request labels link to issue links #12254

Closed
MGChecker opened this issue Jul 15, 2020 · 2 comments · Fixed by #12256
Closed

Pull request labels link to issue links #12254

MGChecker opened this issue Jul 15, 2020 · 2 comments · Fixed by #12256
Labels
type/bug

Comments

@MGChecker
Copy link

  • Gitea version (or commit ref): 1.12.2
  • Operating system: Debian Buster

Description

If you visit a pull request and click at one of the labels, you get to a list of issues with this label. You would expect getting to a list of PRs instead.
@MGChecker
Copy link
Author

For some reason, I am not able to activate PRs at try.gitea.io .

@jolheiser
Copy link
Member

jolheiser commented Jul 15, 2020 •
edited
Loading

I can confirm for you, going to https://try.gitea.io/jolheiser/ciw/pulls/22 and clicking the label will indeed take you to the issues page, filtering for that label. 🙂

EDIT: Of note, the pull list page correctly filters when you click on a label there.

a1012112796 added a commit to a1012112796/gitea that referenced this issue Jul 16, 2020
@a1012112796
[ui] Link to pr list page on sidebar when view pr
3cfd04f 
Fix go-gitea#12254

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 mentioned this issue Jul 16, 2020
Merged
techknowlogick added a commit that referenced this issue Jul 16, 2020
@a1012112796 @techknowlogick
[ui] Link to pr list page on sidebar when view pr (#12256)
0122cf9 
Fix #12254

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
techknowlogick added a commit to techknowlogick/gitea that referenced this issue Jul 16, 2020
@a1012112796 @techknowlogick
[ui] Link to pr list page on sidebar when view pr (go-gitea#12256)
c4ed537 
Fix go-gitea#12254

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@techknowlogick techknowlogick mentioned this issue Jul 16, 2020
Merged
techknowlogick added a commit that referenced this issue Jul 16, 2020
@techknowlogick @a1012112796
[ui] Link to pr list page on sidebar when view pr (#12256) (#12263)
64eaa2a 
Fix #12254

Signed-off-by: a1012112796 <[email protected]>

Co-authored-by: 赵智超 <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue Oct 13, 2020
@zeripath
Finally fix diff names
8c2b61c 
go-gitea#12771 attempted to fix diff by avoiding the git diff line as
it is possible to have an ambiguous line here.

go-gitea#12254 attempted to fix diff by assuming that names would quoted
if they needed to be and if one was quoted then both would be.

Both of these were wrong.

I have now discovered `--src-prefix` and `--dst-prefix` which
means that we can set this in such a way to force the git diff
to always be unambiguous.

Therefore this PR rollsback most of the changes in go-gitea#12771 and
uses these options to fix this.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Oct 13, 2020
Merged
lafriks added a commit that referenced this issue Oct 14, 2020
@zeripath @lafriks
Finally fix diff names (#13136)
edfebe6 
* Finally fix diff names

#12771 attempted to fix diff by avoiding the git diff line as
it is possible to have an ambiguous line here.

#12254 attempted to fix diff by assuming that names would quoted
if they needed to be and if one was quoted then both would be.

Both of these were wrong.

I have now discovered `--src-prefix` and `--dst-prefix` which
means that we can set this in such a way to force the git diff
to always be unambiguous.

Therefore this PR rollsback most of the changes in #12771 and
uses these options to fix this.

Signed-off-by: Andrew Thornton <[email protected]>

* Update services/gitdiff/gitdiff.go

* Update services/gitdiff/gitdiff.go

* Update modules/repofiles/temp_repo.go

* fix test

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ui] Link to pr list page on sidebar when view pr a1012112796/gitea
3 participants
@lafriks @MGChecker @jolheiser