Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While replying to an issue, changes to attachments are applied only if body is also changed #12583

Closed
2 of 7 tasks
CL-Jeremy opened this issue Aug 23, 2020 · 0 comments · Fixed by #13036
Closed
2 of 7 tasks

While replying to an issue, changes to attachments are applied only if body is also changed #12583

CL-Jeremy opened this issue Aug 23, 2020 · 0 comments · Fixed by #13036
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@CL-Jeremy
Copy link
Contributor

Description

As the title suggests, the OP of an issue is not affected. Only replies have to at least have a body for changes to attachments to be applied. Note that the initial upload succeeds without a body. You just cannot change it without changing the body.

See https://try.gitea.io/CL-Jeremy/Test/issues/1#issuecomment-31206, this also happens when there is already some content in body:

1

Newly uploaded files will not be reflected after refreshing until the body is modified (cf. https://try.gitea.io/CL-Jeremy/Test/issues/1#issuecomment-31207):

1
2

Screenshots

cf. https://try.gitea.io/CL-Jeremy/Test/issues/1 (attachments)
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 3, 2020
@zeripath zeripath mentioned this issue Oct 6, 2020
Merged
zeripath added a commit that referenced this issue Oct 10, 2020
@zeripath
Fix attachments list in edit comment (#13036)
7eb8460 
#11141 broke the appearance of dropzone attachments when editting
comments causing poorly updating lists.

This PR fixes this.

Fix #12583

Signed-off-by: Andrew Thornton [email protected]
zeripath added a commit to zeripath/gitea that referenced this issue Oct 11, 2020
@zeripath
Fix attachments list in edit comment (go-gitea#13036)
80babbd 
Backport go-gitea#13036

go-gitea#11141 broke the appearance of dropzone attachments when editting
comments causing poorly updating lists.

This PR fixes this.

Fix go-gitea#12583

Signed-off-by: Andrew Thornton [email protected]
@zeripath zeripath mentioned this issue Oct 11, 2020
Merged
techknowlogick added a commit that referenced this issue Oct 12, 2020
@zeripath @techknowlogick
Fix attachments list in edit comment (#13036) (#13097)
d4af0df 
Backport #13036

#11141 broke the appearance of dropzone attachments when editting
comments causing poorly updating lists.

This PR fixes this.

Fix #12583

Signed-off-by: Andrew Thornton [email protected]

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix attachments list in edit comment zeripath/gitea
2 participants
@CL-Jeremy @zeripath