Panic in routers/repo.ViewIssue() when not logged in

[strk]

This URL serves a blank page if you are not authenticated:
https://try.gitea.io/gitea/gitea/issues/6

\cc @bkcsoft @lunny @appleboy @tboerger (someone who can check the logs?)

[bkcsoft]

Logs:

[Macaron] PANIC: runtime error: invalid memory address or nil pointer dereference
[ ... useless internals ... ]
/srv/app/src/code.gitea.io/gitea/routers/repo/issue.go:468 (0x559181c64448)
[ ... useless internals ... ]
[Macaron] Completed /gitea/gitea/issues/1 500 Internal Server Error in 275.68255ms

Current Gitea-version: 1.1.0+137-g3012971e
Panic here:

gitea/routers/repo/issue.go

Line 468 in 3012971

iw, exists, err := models.GetIssueWatch(ctx.User.ID, issue.ID)

My best guess is that ctx.User isn't populated (nil) if one isn't logged in.

[strk]

Sounds like a correct analisys. So we need a testcase and after that, a fix...

[bkcsoft]

Correction: we need a fix that includes a test-case 🙂