fix bug on issue view when not login #1624
Conversation
routers/repo/issue.go
Outdated
| IsWatching: models.IsWatching(ctx.User.ID, ctx.Repo.Repository.ID), | ||
| } | ||
| } | ||
| } else { | ||
| iw = &models.IssueWatch{ |
There was a problem hiding this comment.
I prefer that iw would stay at nil and in template https://github.com/go-gitea/gitea/blob/master/templates/repo/issue/view_content/sidebar.tmpl#L104 the form is only display if logged or/and IssueWatch is set.
|
LGTM |
tboerger
added
the
lgtm/need 2
|
LGTM |
tboerger
added
lgtm/done
|
@lunny Builds fail though 😢 |
|
@lunny |
integrations/issue_test.go
Outdated
| func TestNoLoginViewIssue(t *testing.T) { | ||
| assert.NoError(t, models.LoadFixtures()) | ||
|
|
||
| req, err := http.NewRequest("GET", "/user1/repo1/issues/1", nil) |
There was a problem hiding this comment.
repo1 is owned by user2 (https://github.com/go-gitea/gitea/blob/master/models/fixtures/repository.yml) -> so /user2/repo1/issues/
Ref :
There was a problem hiding this comment.
I'm confusing there are two fixtures. https://github.com/go-gitea/gitea/blob/master/models/fixtures and integrations/gitea-integration/fixtures,
There was a problem hiding this comment.
In your test you seem to load "code.gitea.io/gitea/models".LoadFixtures() don't know for the other fixture.
|
waiting #1627 |
|
Good idea of removing duplicate fixture. |
lunny
force-pushed
the
lunny/fix_issue_not_login
branch
from
78a21a9 to
6477e37
Compare
|
let L-G-T-M work |
will fix #1539