Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV module includes encoding/csv twice #16557

Closed
richmahn opened this issue Jul 27, 2021 · 1 comment · Fixed by #16631
Closed

CSV module includes encoding/csv twice #16557

richmahn opened this issue Jul 27, 2021 · 1 comment · Fixed by #16631
Assignees
@richmahn
Labels
type/bug

Comments

@richmahn
Copy link
Contributor

  • Gitea version (or commit ref): 4b6370c (main)

Description

No need to import encoding/csv twice:

gitea/modules/csv/csv.go

Line 9 in 4b6370c

"encoding/csv"

Use stdcsv here and below:

gitea/modules/csv/csv.go

Line 100 in 4b6370c

var perr *csv.ParseError

@richmahn richmahn self-assigned this Jul 27, 2021
@lunny lunny added the type/bug label Jul 27, 2021
@lunny
Copy link
Member

lunny commented Jul 27, 2021

Good catch

richmahn added a commit to richmahn/gitea that referenced this issue Aug 5, 2021
@richmahn
Fixes go-gitea#16557 - duplicate csv import
432d48c
@richmahn richmahn mentioned this issue Aug 5, 2021
Merged
zeripath pushed a commit that referenced this issue Aug 5, 2021
@richmahn
Fixes #16557 - duplicate csv import (#16631)
fd39e6d 
Remove the unnecessary duplicate package import for `encoding/csv` in `modules/csv/csv.go`

Fix #16557
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richmahn richmahn

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate csv import in modules/csv/csv.go richmahn/gitea
2 participants
@lunny @richmahn