Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of commits from push listed on the start page is wrong #16804

Closed
whannes opened this issue Aug 24, 2021 · 4 comments · Fixed by #16811
Closed

Number of commits from push listed on the start page is wrong #16804

whannes opened this issue Aug 24, 2021 · 4 comments · Fixed by #16811
Labels
type/bug
Milestone
1.15.1

Comments

@whannes
Copy link

whannes commented Aug 24, 2021

The number of commits from a push listed on the start page refers to the number of items in the list rather than the actual number of commits:
grafik
grafik
@lunny lunny added the type/bug label Aug 24, 2021
@lunny lunny added this to the 1.15.1 milestone Aug 24, 2021
@lunny
Copy link
Member

lunny commented Aug 24, 2021

I also found the bug. Even if you push one commit, but it will always display recent 5 commits.

@zeripath
Copy link
Contributor

zeripath commented Aug 24, 2021 •
edited
Loading

Found the fix - I'll have a PR up imminently.

Nope I'm wrong here - I was looking at old data where the Len was present. The problem we now face is that the action table is being incorrectly created without the full Len data.

zeripath added a commit to zeripath/gitea that referenced this issue Aug 24, 2021
@zeripath
Report the correct number of pushes on the feeds
b27dbb3 
Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix go-gitea#16804

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Aug 24, 2021
Closed
@zeripath
Copy link
Contributor

zeripath commented Aug 24, 2021 •
edited
Loading

OK This is a regression from #16282

This will need a migration and/or a doctor script to fix.

zeripath added a commit to zeripath/gitea that referenced this issue Aug 24, 2021
@zeripath
Report the correct number of pushes on the feeds
2eefed9 
Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix go-gitea#16804

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Aug 24, 2021
Merged
@zeripath
Copy link
Contributor

Unfortunately I think the correct length for these actions is unrecoverable. ☹️

techknowlogick added a commit that referenced this issue Aug 25, 2021
@zeripath @techknowlogick
Report the correct number of pushes on the feeds (#16811)
ba6baff 
* Report the correct number of pushes on the feeds

Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix #16804

Signed-off-by: Andrew Thornton <[email protected]>

* Update templates/user/dashboard/feeds.tmpl

Co-authored-by: techknowlogick <[email protected]>
techknowlogick added a commit to techknowlogick/gitea that referenced this issue Aug 26, 2021
@zeripath @techknowlogick
Report the correct number of pushes on the feeds (go-gitea#16811)
9cc9c7c 
* Report the correct number of pushes on the feeds

Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix go-gitea#16804

Signed-off-by: Andrew Thornton <[email protected]>

* Update templates/user/dashboard/feeds.tmpl

Co-authored-by: techknowlogick <[email protected]>
@techknowlogick techknowlogick mentioned this issue Aug 26, 2021
Merged
techknowlogick added a commit that referenced this issue Aug 26, 2021
@techknowlogick @zeripath
Report the correct number of pushes on the feeds (#16811) (#16822)
0c7927f 
* Report the correct number of pushes on the feeds

Since the number of commits in the Action table has been limited to 5
the number of commits reported on the feeds page is now incorrectly also
limited to 5. The correct number is available as the Len and this PR
changes this to report this.

Fix #16804

Signed-off-by: Andrew Thornton <[email protected]>

* Update templates/user/dashboard/feeds.tmpl

Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.15.1
3 participants
@lunny @zeripath @whannes