Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source code line's comments are not taken into account on Pull Requests page #22419

Closed
kuraga opened this issue Jan 12, 2023 · 4 comments · Fixed by #30556
Closed

Source code line's comments are not taken into account on Pull Requests page #22419

kuraga opened this issue Jan 12, 2023 · 4 comments · Fixed by #30556
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/bug

Comments

@kuraga
Copy link

kuraga commented Jan 12, 2023 •
edited
Loading

Description

On the Gitea demo site, source code line's comments are not taken into account on Pull Requests page. So, they are not added to the count of the MR's comments count.

Gitea Version

1.19.0+dev-291

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I visit it via a browser.

Database

None
@kuraga kuraga changed the title Source code line's comments are not taken into account on Merge Requests page Source code line's comments are not taken into account on Pull Requests page Jan 12, 2023
@lunny
Copy link
Member

lunny commented Jan 13, 2023

Should they be counted?

@kuraga
Copy link
Author

kuraga commented Jan 13, 2023

Well I think 'there are no comments' if there is not a badge (on Pull Requests page). But they are.

@silverwind
Copy link
Member

I agree, line comments should count towards the comment count. This is how it works on GitHub as well.

@silverwind silverwind added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Jan 13, 2023
@metiftikci metiftikci mentioned this issue May 23, 2024
Closed
@lunny lunny mentioned this issue May 24, 2024
Merged
@kuraga
Copy link
Author

kuraga commented Aug 1, 2024

#30556

@GiteaBot GiteaBot mentioned this issue Dec 30, 2024
Merged
lunny added a commit that referenced this issue Dec 30, 2024
@GiteaBot @lunny
Fix issue comment number (#30556) (#33055)
968c04c 
Backport #30556 by @lunny

Fix #22419

Only comments with types `CommentTypeComment` and `CommentTypeReview`
will be counted as conversations of the pull request.
`CommentTypeReview` was missed in the previous implementation.

Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue comment number lunny/gitea
3 participants
@lunny @silverwind @kuraga