Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 when browser tag tree #2364

Closed
1 of 7 tasks
zhsj opened this issue Aug 23, 2017 · 3 comments · Fixed by #2408
Closed
1 of 7 tasks

404 when browser tag tree #2364

zhsj opened this issue Aug 23, 2017 · 3 comments · Fixed by #2408
Assignees
Labels
Milestone

Comments

@zhsj
Copy link

zhsj commented Aug 23, 2017

Description

I can't browser the git tree, maybe caused by the tag contains slash?

@lafriks lafriks added this to the 1.x.x milestone Aug 23, 2017
@ethantkoenig
Copy link
Member

I believe the problem is that this repo also has a branch named upstream. When the RepoRef(..) handler sees src/upstream/1.0.2+dfsg, it thinks you're asking for the 1.0.2+dfsg tree-path in the upstream branch.

Working on a fix

@ethantkoenig
Copy link
Member

I think we'll need to change our URL schemes, for the following reason:

Suppose I have a repo with a file foo, a branch bar, and a tag bar/foo. If I request .../src/bar/foo there is no way to tell whether I want to view the foo file on branch bar, or I if want to view the root directory for tag bar/foo.

@lunny
Copy link
Member

lunny commented Aug 27, 2017

It seems github has also the problem with the route.

@lunny lunny modified the milestones: 1.x.x, 1.3.0 Oct 30, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants