-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make URL scheme unambiguous #2408
Conversation
cf5e6eb
to
c2e23d6
Compare
Is it possible to migrate links from older comments to the new URL scheme to avoid dead links? |
@JonasFranzDEV I think a better solution to dead links is to have old links redirect to their new counterparts. I'll work on adding redirects soon. |
|
@sapk Isn't swagger just for API endpoints? |
Yes. I think swagger only for API? This PR's break links is for UI. |
@lunny @ethantkoenig sorry misread ... |
f46f667
to
0230432
Compare
@JonasFranzDEV @sapk Added redirects from old URL scheme to new scheme |
0230432
to
32c6859
Compare
Codecov Report
@@ Coverage Diff @@
## master #2408 +/- ##
==========================================
- Coverage 26.86% 26.85% -0.01%
==========================================
Files 89 89
Lines 17596 17601 +5
==========================================
Hits 4727 4727
- Misses 12183 12188 +5
Partials 686 686
Continue to review full report at Codecov.
|
32c6859
to
6c33cad
Compare
Rebased to resolve conflicts |
d45690b
to
1b94318
Compare
@ethantkoenig can you please resolve conflicts so this can be tested? |
1b94318
to
0bd43c6
Compare
@lafriks Rebased |
LGTM |
cannot switch to another branch on the menus. |
@lunny Will take a look by Sunday at latest |
@lunny Fixed. There were actually two problems:
Both problems are fixed |
77f6d5d
to
80d23a4
Compare
Redirect old routes to new routes
80d23a4
to
865dd24
Compare
Rebasing to re-run CI (passes locally) |
LGTM |
Fixes #2364. Modifies URL schemes to remove ambiguity (see #2364 (comment))
The
GET /:owner/:repo/src/*
endpoint becomes three endpoints:GET /:owner/:repo/src/branch/*
GET /:owner/:repo/src/tag/*
GET /:owner/:repo/src/commit/*
Similarly for
GET /:owner/:repo/raw/*
andGET /:owner/:repo/commits/*
. The old routes are redirected to the new routes to maintain backward compatibility.