Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to delete milestones #25557

Closed
Fratee opened this issue Jun 28, 2023 · 2 comments · Fixed by #25583
Closed

Unable to delete milestones #25557

Fratee opened this issue Jun 28, 2023 · 2 comments · Fixed by #25583
Labels
type/bug

Comments

@Fratee
Copy link

Fratee commented Jun 28, 2023

Description

Cannot delete milestone after creation, same happens if the milestone is closed beforehand.

Steps to reproduce:

  1. Create a new repository
  2. Create a new milestone
  3. Close the milestone
  4. Delete the milestone

Expected behaviour:
The milestone is deleted

Actual behaviour:
The milestone is still present when the page refreshes

Gitea Version

1.20.0-rc0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows 10

How are you running Gitea?

Self hosted on windows 10

Database

SQLite
@lunny
Copy link
Member

lunny commented Jun 28, 2023

Which repository did you test in try site?

@HesterG HesterG mentioned this issue Jun 29, 2023
Merged
silverwind pushed a commit that referenced this issue Jun 29, 2023
@HesterG
Fix milestones deletion (#25583)
5a87193 
Close #25557 
Fix regression from #25315

`data-id` is still needed for deleting milestone.
@GiteaBot GiteaBot mentioned this issue Jun 29, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 29, 2023
@HesterG @GiteaBot
Fix milestones deletion (go-gitea#25583)
74f6162 
Close go-gitea#25557 
Fix regression from go-gitea#25315

`data-id` is still needed for deleting milestone.
silverwind pushed a commit that referenced this issue Jun 29, 2023
@GiteaBot @HesterG
Fix milestones deletion (#25583) (#25584)
51b6a78 
Backport #25583 by @HesterG

Close #25557 
Fix regression from #25315

`data-id` is still needed for deleting milestone.

Co-authored-by: HesterG <[email protected]>
@Fratee
Copy link
Author

Fratee commented Jun 29, 2023 •
edited
Loading

Which repository did you test in try site?

https://try.gitea.io/Fratee/Unable_to_delete_milestones
but i guess it doesn't matter as it has been fixed already.

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix milestones deletion HesterG/gitea
2 participants
@lunny @Fratee