Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MySQL 5.7 support #25657

Closed
silverwind opened this issue Jul 3, 2023 · 9 comments · Fixed by #27337
Closed

Drop MySQL 5.7 support #25657

silverwind opened this issue Jul 3, 2023 · 9 comments · Fixed by #27337
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/deprecation Previously provided functionality is removed type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

silverwind commented Jul 3, 2023 •
edited
Loading

MySQL 5.7 will reach EOL in 4 months. We should:

  • Drop it from CI matrix and remove relevant Makefile targets
  • Update docs that MySQL 8.0 or greater is required
@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jul 3, 2023
@silverwind silverwind changed the title Drop MySQL 5 support Drop MySQL 5.7 support Jul 3, 2023
@silverwind silverwind added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/deprecation Previously provided functionality is removed and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jul 3, 2023
@lunny
Copy link
Member

lunny commented Jul 4, 2023

We can do it step by step. Firstly prevent new installation to chose mysql 5.7 but that askes Gitea read versions from database.

@silverwind
Copy link
Member Author

I'm primarily looking to remove it from CI. We don't need to deliberatily go out of the way to break it for users unless there are valid reasons to do so.

@lunny
Copy link
Member

lunny commented Jul 4, 2023

Maybe we can have an announcement for that first and maybe 1.22 is a better version to remove mysql5.7 CI and new installation?

@silverwind
Copy link
Member Author

silverwind commented Jul 4, 2023 •
edited
Loading

Sounds ok. We should remove it from CI after 1.22 branch is created. Don't think it needs any big announcement, just update requirements in the docs.

@yakob-aleksandrovich
Copy link

Is there already a roadmap for when support for MySQL 5.7 will be fully dropped? Which branch would that be?
This would help me and various others in planning for an upgrade of our infrastructure.

@delvh
Copy link
Member

delvh commented Sep 27, 2023

…

main, since the instant we forked the release/v1.21 branch.

So far, we haven't dropped MySQL 5.7 support.
If it happens, it will probably happen around or after the release of 1.21.0, but not before.

@silverwind
Copy link
Member Author

Will likely happen in 1.22.

@delvh
Copy link
Member

delvh commented Sep 27, 2023

Yes, but the question was when exactly is 'in 1.22'.
The range ranges from now to feature freeze in three months…

@silverwind
Copy link
Member Author

It shouldn't really matter. It will be a sort of soft-deprecation of support anyways, e.g. in theory 5.7 will still work in 1.22, we just don't actively test it anymore, and will start testing 8.0 and likely 8.1 instead.

silverwind added a commit to silverwind/gitea that referenced this issue Sep 28, 2023
@silverwind
Require MySQL >= 8.0, test with 8.1
6c33aa9 
- MySQL 5.7 support and testing is dropped
- MySQL tests now only test against 8.1, previously it was 5.7 and 8.0

Fixes: go-gitea#25657
@silverwind silverwind mentioned this issue Sep 28, 2023
Merged
techknowlogick added a commit that referenced this issue Oct 3, 2023
@silverwind @techknowlogick
Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 (#27337)
e94f9fc 
- MySQL 5.7 support and testing is dropped
- MySQL tests now execute against 8.1, up from 5.7 and 8.0
- PostgreSQL 10 and 11 support ist dropped
- PostgreSQL tests now execute against 16, up from 15
- MSSQL 2008 support is dropped
- MSSQL tests now run against locked 2022 version

Fixes: #25657

Ref: https://endoflife.date/mysql
Ref: https://endoflife.date/postgresql
Ref: https://endoflife.date/mssqlserver

## ⚠️ BREAKING ⚠️

Support for MySQL 5.7, PostgreSQL 10 and 11, and MSSQL 2008 is dropped.
You are encouraged to upgrade to supported versions.

---------

Co-authored-by: techknowlogick <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/deprecation Previously provided functionality is removed type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 silverwind/gitea
4 participants
@lunny @silverwind @yakob-aleksandrovich @delvh