Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch name escape problem #25865

Closed
yp05327 opened this issue Jul 13, 2023 · 4 comments · Fixed by #25875
Closed

Branch name escape problem #25865

yp05327 opened this issue Jul 13, 2023 · 4 comments · Fixed by #25875
Labels
type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Jul 13, 2023 •
edited
Loading

Description

Related: #25830

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@yp05327 yp05327 mentioned this issue Jul 13, 2023
Merged
@puni9869
Copy link
Member

Thanks for summarizing it in short.
You are correct about Github.

@yp05327 yp05327 mentioned this issue Jul 14, 2023
Merged
@silverwind
Copy link
Member

I don't get it. What is wrong on https://try.gitea.io/yp05327/testrepo/src/branch/test%2311?

@puni9869
Copy link
Member

Thats the correct url for test#11 branch. Nothing wrong with it.

@yp05327
Copy link
Contributor Author

yp05327 commented Jul 20, 2023

I don't get it. What is wrong on https://try.gitea.io/yp05327/testrepo/src/branch/test%2311?

After access this link, you can select this branch again in the selector.
Then the url will become https://try.gitea.io/yp05327/testrepo/src/branch/test#11

silverwind pushed a commit that referenced this issue Jul 21, 2023
@yp05327
Fix escape problems in the branch selector (#25875)
d57e55c 
Fix #25865
@GiteaBot GiteaBot mentioned this issue Jul 25, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jul 25, 2023
@yp05327 @GiteaBot
Fix escape problems in the branch selector (go-gitea#25875)
cc8f402 
Fix go-gitea#25865
lunny pushed a commit that referenced this issue Jul 25, 2023
@GiteaBot @yp05327
Fix escape problems in the branch selector (#25875) (#26103)
3e07c54 
Backport #25875 by @yp05327

Fix #25865

Co-authored-by: yp05327 <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@GiteaBot @earl-warren
Fix escape problems in the branch selector (go-gitea#25875) (go-gitea…
9fae415 
…#26103)

Backport go-gitea#25875 by @yp05327

Fix go-gitea#25865

Co-authored-by: yp05327 <[email protected]>
(cherry picked from commit 3e07c54)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix escape problems in the branch selector yp05327/gitea
3 participants
@silverwind @yp05327 @puni9869