Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot filter issue search results by label/milestone/project/assignee/type #26536

Closed
CaiCandong opened this issue Aug 16, 2023 · 2 comments · Fixed by #26539
Closed

Cannot filter issue search results by label/milestone/project/assignee/type #26536

CaiCandong opened this issue Aug 16, 2023 · 2 comments · Fixed by #26539
Labels
type/bug

Comments

@CaiCandong
Copy link
Member

CaiCandong commented Aug 16, 2023 •
edited
Loading

Description

as title
relate indexer

ScreenShot

Only the label case is shown, the rest milestone/project/assignee/type cases as it too.
before

try.gitea.io

https://try.gitea.io/CaiCandong/dotfiles/issues?q=DSCD&type=all&sort=&state=open&labels=24194&milestone=0&project=0&assignee=0&poster=0

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

development

Database

None
@CaiCandong CaiCandong self-assigned this Aug 16, 2023
@CaiCandong CaiCandong changed the title Cannot filter issue search results by label Cannot filter issue search results by label/milestone/project/assignee/type Aug 16, 2023
@yp05327
Copy link
Contributor

yp05327 commented Aug 16, 2023 •
edited
Loading

It seems that combined filters not work well

And this one, only two labels selected:
https://try.gitea.io/CaiCandong/dotfiles/issues?q=&type=all&sort=&state=open&labels=24194%2c24195&milestone=0&project=0&assignee=0&poster=0
It seems that the logic is and not or.

@CaiCandong
Copy link
Member Author

It seems that the logic is and not or.

That's not what was discussed. Try the three links below:

@CaiCandong CaiCandong removed their assignment Aug 16, 2023
@wolfogre wolfogre mentioned this issue Aug 16, 2023
Merged
lunny pushed a commit that referenced this issue Aug 16, 2023
@wolfogre
Add missing triggers to update issue indexer (#26539)
7e75e58 
Fix #26536

Follow #26012

Whatever the comment type is, always update the issue indexer. So the
issue indexer will be updated when there is a change in Status,
Assignee, Label, and so on.

I added the logic for `NotifyUpdateComment`, but missed it for
`NotifyCreateIssueComment` and `NotifyDeleteComment`.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing triggers to update issue indexer
2 participants
@yp05327 @CaiCandong