Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The second dependency in issue is marked as private #28732

Closed
mature-woman opened this issue Jan 8, 2024 · 3 comments · Fixed by #27736
Closed

The second dependency in issue is marked as private #28732

mature-woman opened this issue Jan 8, 2024 · 3 comments · Fixed by #27736
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@mature-woman
Copy link

Description

In the dependencies block of the issues section, the second dependency displays a lock icon with the caption "You do not have permission to view this dependency" (translated from russian)

This dependency is issue within the same public repository, and i am an administrator and should see ALL issues, even private ones

If you go to this issues directly, it is displayed without any problems

I will provide additional information upon request

Screenshots

изображение

Gitea Version

1.22.0+dev-514-gdd5693387 built with GNU Make 4.3, go1.21.4 : bindata

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Ubuntu 22

Browser Version

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:120.0) Gecko/20100101 Firefox/120.0

@mature-woman mature-woman added topic/ui Change the appearance of the Gitea UI type/bug labels Jan 8, 2024
@mature-woman
Copy link
Author

mature-woman commented Jan 8, 2024

3 projects

2 project depends on 1 projects
Project 3 depends on projects 1 and 2

in the "BLOCK" section of project 1 only project 3 is displayed

1 project (blockchain):
изображение
for some reason there is no chat in block section and it won't let me add it with the message "You can't create a dependency with two tasks blocking each other"

2 project (chat):
изображение

3 project (forum):
изображение

@colejohnson66
Copy link

colejohnson66 commented Jan 9, 2024

Dupe of #27722

@mature-woman
Copy link
Author

Dupe of #27722

sorry

lafriks pushed a commit that referenced this issue Jan 12, 2024
Backport #27736 by @lng2020

Fix #27722 
Fix #27357
Fix #25837 
Fix #28732 
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)

Co-authored-by: Nanguan Lin <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
Backport go-gitea#27736 by @lng2020

Fix go-gitea#27722
Fix go-gitea#27357
Fix go-gitea#25837
Fix go-gitea#28732
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)

Co-authored-by: Nanguan Lin <[email protected]>
(cherry picked from commit 571822b)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants