Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display of bot accounts on UI #33469

Open
typed-sigterm opened this issue Feb 1, 2025 · 5 comments
Open

Better display of bot accounts on UI #33469

typed-sigterm opened this issue Feb 1, 2025 · 5 comments
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@typed-sigterm
Copy link
Contributor

typed-sigterm commented Feb 1, 2025

Description

Although bots (type = 4) cannot sign in, the checkbox is still available:
image

And I don't think these features are applicable to bots - GitHub also disables them:
image

Perhaps we can add a Bot badge on the account page of the bots and the org/team page, just like on the management page:
image

Link #24026 #13044.

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

See above

Git Version

2.47.1

Operating System

Ubuntu 24.04.1

How are you running Gitea?

Not so important

Database

None

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI and removed type/bug labels Feb 1, 2025
@lunny
Copy link
Member

lunny commented Feb 1, 2025

I believe this is a bug. The bot account type was added without proper UI integration, leaving many inconsistencies across the system. Moving forward, we should avoid introducing incomplete features and focus on building a well-designed system.

Key considerations:
- Clearly define the differences between a bot account and a regular user account.
- If a bot user cannot log in, how should tokens be generated? Should we introduce a “sudo” mode for web operations, similar to API access?
- How does a bot user differ from an app user if we plan to implement a GitHub-style App system?

By addressing these points, we can ensure a more robust and user-friendly implementation.

@typed-sigterm
Copy link
Contributor Author

  • If a bot user cannot log in, how should tokens be generated? Should we introduce a “sudo” mode for web operations, similar to API access?

It seems that API sudo mode cannot generate an access token for another either, and the token generated by gitea admin user create --access-token has no scope. I must manually edit its scopes in the database.

@techknowlogick
Copy link
Member

@lunny it was implemented that way intentionally, as a minimal implementation. Rather than a large PR, multiple minor enhancements were made. Since it is still not possible to set a user as a bot without modifying the database this approach was found suitable so at least some advanced users could attempt to use it.

@typed-sigterm
Copy link
Contributor Author

Also, I think bot activities should be excluded from the dashboard.

@lunny
Copy link
Member

lunny commented Feb 12, 2025

Also, I think bot activities should be excluded from the dashboard.

Maybe it should be an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants