Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add "bot account" as a type of user #13044

Open
7 tasks
a1012112796 opened this issue Oct 6, 2020 · 14 comments
Open
7 tasks

[Proposal] Add "bot account" as a type of user #13044

a1012112796 opened this issue Oct 6, 2020 · 14 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@a1012112796
Copy link
Member

a1012112796 commented Oct 6, 2020

  • Gitea version (or commit ref):
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Hello, Sometimes we will want add a new accout which only used by bot apps to call api. So I think maybe we can add it as a new user type. It maybe follow this tips.

  • Bot account willn't login on ui page
  • Bot account maybe should not have ability create it's own repos
  • Each boat account should belong to a user or an org, and this user or the owners of this org can change the setting of the bot account. (important)
  • manager can limit the max number of the bot acounts that one user and org can have
  • Bot account is not necessary to request email and the system will't send email notify and action notify to them also
  • show bot label on frofile page
  • ......

Maybe usefull to fix #12985.

Screenshots

@a1012112796 a1012112796 changed the title [Proposal] Add "bot acount" as a type of user type [Proposal] Add "bot acount" as a type of user Oct 6, 2020
@a1012112796 a1012112796 changed the title [Proposal] Add "bot acount" as a type of user [Proposal] Add "bot account" as a type of user Oct 6, 2020
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 7, 2020
@silverwind
Copy link
Member

silverwind commented Oct 8, 2020

  • Bot account should not have a password, or if git password auth is really desired, should have it optional with the ability to unset password.
  • Bot account should have the ability to create app tokens and add ssh/gpg keys.

@basxto
Copy link

basxto commented Nov 1, 2020

This would also be interesting for gpg key checks of mirrored repositories.
You could just add a bot for the original owner.

@mscherer
Copy link
Contributor

I would say that multiple owners could also be useful, so more than 1 person can operate the bot (useful if one of the owner is away)

@lafriks
Copy link
Member

lafriks commented Nov 18, 2020

My proposal would be:

  • Bot can be server wide (managed by server admins) - owner_id = nil
  • Bot can be organization owned (managed by organization admins) - owner_id = organization id
  • Bot can be user owned (managed by single user) - owner_id = user id

@a1012112796
Copy link
Member Author

a1012112796 commented Nov 18, 2020

now, I found it in gh, maybe we can add a similar mechanism.
https://docs.github.com/en/free-pro-team@latest/developers/apps/about-apps#about-github-apps

@stale
Copy link

stale bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 17, 2021
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 18, 2021
@stale stale bot removed the issue/stale label Jan 18, 2021
@jpraet
Copy link
Member

jpraet commented Jan 11, 2022

I have a bot account in my CI pipeline that adds commits to PR's (code formatting and cleanup, dependency upgrades, ..).
We trust this bot, so these commits don't require review. But these commits cause the earlier approvals of the PR to become stale.
Is that something that could be included in the requirements for the bot account implementation?

@dpschen
Copy link

dpschen commented Feb 7, 2022

Maybe this can also be used to change the sort order in the request review dropdown:
Because we have a bot that deploys a preview and creates a comment with a preview link the bot will always appear as the first suggestion in the list.

@rakshith-ravi
Copy link
Contributor

Have there been any proposals to implement this? If one were to start implementing this, what would be a good starting point?

@a1012112796
Copy link
Member Author

Have there been any proposals to implement this? If one were to start implementing this, what would be a good starting point?

looks github app is similar with this.

@techknowlogick
Copy link
Member

So technically there is now a type of bot, but it doesn't have any logic for displaying a badge etc..

@rakshith-ravi
Copy link
Contributor

So technically there is now a type of bot, but it doesn't have any logic for displaying a badge etc..

You mean with current Gitea? How would bot accounts work with the existing version?

@delvh
Copy link
Member

delvh commented May 20, 2023

Well… We recognize them since #24026.
Practically, however, the only effect this has at the moment is prohibiting login and reserving the username.
Have a look at the PR for more details.

@Frankkkkk
Copy link
Contributor

Related somewhat: Support configuring permissions of automatic tokens of Actions jobs #24635

wxiaoguang added a commit that referenced this issue Feb 7, 2025
…play (#27885)

Partially solve #13044

Fix #33295

---------

Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests