Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md not working with Git LFS #6073

Closed
2 of 7 tasks
simonmeusel opened this issue Feb 14, 2019 · 3 comments · Fixed by #6099
Closed
2 of 7 tasks

README.md not working with Git LFS #6073

simonmeusel opened this issue Feb 14, 2019 · 3 comments · Fixed by #6099
Labels
type/enhancement An improvement of existing functionality
Milestone
1.8.0

Comments

@simonmeusel
Copy link

  • Gitea version (or commit ref): 353282e
  • Git version: 2.20.1
  • Operating system: Linux with Docker
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When creating a README.md file and tracking it with Git LFS, it will be displayed in the wrong way. When individually clicking the README.md and downloading it (View raw), the right content gets downloaded.

Screenshots

s

a
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 15, 2019
@zeripath
Copy link
Contributor

Hmm... I can't believe that anyone would place their markdown readme file in LFS - however, I suppose for completeness sake I can adjust this.

Should we be allowing other formats like readme pdf etc?

@zeripath zeripath mentioned this issue Feb 16, 2019
Merged
@simonmeusel
Copy link
Author

simonmeusel commented Feb 17, 2019 •
edited
Loading

I tracked my README.md with Git LFS by accident (by tracking all files with Git LFS), but if you include Base64 images in the README.md, there is a good reason to track the README.md with Git LFS.

Should we be allowing other formats like readme pdf etc?

Not as part of this issue, but generally why not?

@zeripath
Copy link
Contributor

zeripath commented Feb 17, 2019 •
edited
Loading

It would simplify the code somewhat, we just make the readme section call the view file section with the appropriate information and set the template similarly

techknowlogick pushed a commit that referenced this issue Feb 21, 2019
@zeripath @techknowlogick
Allow display of LFS stored Readme.md on directory page (#6073) (#6099)
3b61ff1 
* Fix display of >1Kb LFS text files

* Make LFS stored Readme files viewable

Signed-off-by: Andrew Thornton <[email protected]>

* Slight restructure

Signed-off-by: Andrew Thornton <[email protected]>

* Slight restructure

Signed-off-by: Andrew Thornton <[email protected]>

* catch errors and restructure LFS sections
@lafriks lafriks added this to the 1.8.0 milestone Feb 23, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Allow display of LFS stored Readme.md on directory page (#6073) zeripath/gitea
3 participants
@lafriks @zeripath @simonmeusel