Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified pagination template #6531

Closed
saitho opened this issue Apr 7, 2019 · 0 comments · Fixed by #6533
Closed

Unified pagination template #6531

saitho opened this issue Apr 7, 2019 · 0 comments · Fixed by #6533
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@saitho
Copy link
Contributor

saitho commented Apr 7, 2019

There is a template for the pagination bar (templates/base/paginate.tmpl). However, this template is not used in all templates that use a pagination.

The HTML structure is the same. The only difference is the additional URL params used for the pagination links. The pagination template should be adjusted to be able to configure these URL params and be used on all templates that use pagination.
@saitho saitho mentioned this issue Apr 7, 2019
Merged
@saitho saitho mentioned this issue Apr 7, 2019
Merged
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 8, 2019
saitho added a commit to saitho/gitea that referenced this issue Apr 13, 2019
@saitho
Unifies pagination template usage (go-gitea#6531)
b2737be 
Signed-off-by: Mario Lubenka <[email protected]>
saitho added a commit to saitho/gitea that referenced this issue Apr 13, 2019
@saitho
Introduce extended paginater component (go-gitea#6531)
0a5195e 
Signed-off-by: Mario Lubenka <[email protected]>
saitho added a commit to saitho/gitea that referenced this issue Apr 19, 2019
@saitho
Fix string casting in pagination.go (go-gitea#6531)
050a240 
Signed-off-by: Mario Lubenka <[email protected]>
saitho added a commit to saitho/gitea that referenced this issue Apr 19, 2019
@saitho
Store urlParams as array of strings instead of template.URL (go-gitea…
4ff56b2 
…#6531)

Signed-off-by: Mario Lubenka <[email protected]>
techknowlogick pushed a commit that referenced this issue Apr 20, 2019
@saitho @techknowlogick
Unifies pagination template usage (#6531) (#6533)
fcbac38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unifies pagination template usage (#6531) saitho/gitea
2 participants
@lafriks @saitho