Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When closing a pull request, it should ask if the branch should be deleted #6570

Closed
saitho opened this issue Apr 10, 2019 · 0 comments · Fixed by #6601
Closed

When closing a pull request, it should ask if the branch should be deleted #6570

saitho opened this issue Apr 10, 2019 · 0 comments · Fixed by #6601
Labels
type/enhancement An improvement of existing functionality
Milestone
1.9.0

Comments

@saitho
Copy link
Contributor

saitho commented Apr 10, 2019

When closing a pull request it is easy to forget to delete the branch if it's not needed anymore.
Therefore Gitea should show the "delete branch" box which is currently only shown after a pull request has been merged.
@lunny lunny added the type/enhancement An improvement of existing functionality label Apr 11, 2019
saitho added a commit to saitho/gitea that referenced this issue Apr 13, 2019
@saitho
Show button to delete a pull request branch after a pull request has …
2da2863 
…been closed (go-gitea#6570)

Signed-off-by: Mario Lubenka <[email protected]>
@saitho saitho mentioned this issue Apr 13, 2019
Merged
@lunny lunny added this to the 1.9.0 milestone Apr 20, 2019
lafriks pushed a commit that referenced this issue Apr 20, 2019
@saitho @lafriks
Show "delete branch" button on closed pull requests (#6570) (#6601)
bc86134 
* Show button to delete a pull request branch after a pull request has been closed (#6570)

Signed-off-by: Mario Lubenka <[email protected]>

* Update routers/repo/pull.go

Co-Authored-By: saitho <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Show "delete branch" button on closed pull requests (#6570) saitho/gitea
2 participants
@lunny @saitho