Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Cross-link commits mentioning other repos #6664

Closed
2 of 7 tasks
stani0502 opened this issue Apr 17, 2019 · 4 comments · Fixed by #6694
Closed
2 of 7 tasks

Feature Request: Cross-link commits mentioning other repos #6664

stani0502 opened this issue Apr 17, 2019 · 4 comments · Fixed by #6694
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.9.0

Comments

@stani0502
Copy link

stani0502 commented Apr 17, 2019 •
edited
Loading

  • Gitea version (or commit ref):8d01b98
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Refering to this pull request #6273, on this pull request say able to link issue to another repo
I tried in here https://try.gitea.io/stani0502/coba.
i tried commit and put url of the issue from different repo to link this issue https://try.gitea.io/stani0502/test/issues/1.
But is not working.
Let me know how the correct way to do that.

...

Screenshots

image
image
@mrsdizzie
Copy link
Member

I'm not sure I understand -- the box you have drawn in the first screenshot shows the issue reference as a link and when clicking on your example link of https://try.gitea.io/stani0502/coba it also shows the proper link where the text stani0502/test#1 is a link to https://try.gitea.io/stani0502/test/issues/1

What are you expecting to happen?

@stani0502
Copy link
Author

i expecting something like this
image

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 17, 2019
@techknowlogick
Copy link
Member

Ah, so it's not that something isn't working. It's that something hasn't been implemented yet.

@stani0502
Copy link
Author

ah okay, i thought that fixed for that kind feature.

@techknowlogick techknowlogick changed the title Auto link not working. Feature Request: Cross-link commits mentioning other repos Apr 17, 2019
@mrsdizzie mrsdizzie mentioned this issue Apr 20, 2019
Merged
@lunny lunny added this to the 1.9.0 milestone May 2, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 24, 2025
@Gusted
[v7.0/forgejo] fix: load settings for valid user and email check
51e0b34 
- The doctor commands to check the validity of existing usernames and
email addresses depend on functionality that have configurable behavior
depending on the values of the `[service]` settings, so load them when
running the doctor command.
- Resolves go-gitea#6664
- No unit test due to the architecture of doctor commands.

(cherry picked from commit 46e60ce)
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 24, 2025
@Gusted
[v10.0/forgejo] fix: load settings for valid user and email check (go…
553fc3c 
…-gitea#6678)

**Backport:** https://codeberg.org/forgejo/forgejo/pulls/6674

- The doctor commands to check the validity of existing usernames and
email addresses depend on functionality that have configurable behavior
depending on the values of the `[service]` settings, so load them when
running the doctor command.
- Resolves go-gitea#6664
- No unit test due to the architecture of doctor commands.

Co-authored-by: Gusted <[email protected]>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6678
Reviewed-by: Gusted <[email protected]>
Co-authored-by: forgejo-backport-action <[email protected]>
Co-committed-by: forgejo-backport-action <[email protected]>
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 24, 2025
@Gusted
fix: load settings for valid user and email check (go-gitea#6674)
46e60ce 
- The doctor commands to check the validity of existing usernames and
email addresses depend on functionality that have configurable behavior
depending on the values of the `[service]` settings, so load them when
running the doctor command.
- Resolves go-gitea#6664
- No unit test due to the architecture of doctor commands.

# Testing

1. Set `[service].ALLOW_DOTS_IN_USERNAMES = true`.
2. Create a user that contains a dot in their username.
3. Run the `check-user-name` doctor command and verify there's no error reported.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6674
Reviewed-by: Earl Warren <[email protected]>
Co-authored-by: Gusted <[email protected]>
Co-committed-by: Gusted <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Improve issue reference on commit mrsdizzie/gitea
4 participants
@lunny @techknowlogick @mrsdizzie @stani0502