Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Time tracking #967

Closed
mixedCase opened this issue Feb 18, 2017 · 17 comments · Fixed by #2211
Closed

Feature request: Time tracking #967

mixedCase opened this issue Feb 18, 2017 · 17 comments · Fixed by #2211
Labels
outdated/theme/timetracker type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@mixedCase
Copy link

mixedCase commented Feb 18, 2017

Gogs issue describing the idea behind the request: gogs/gogs#879

GitLab implements it for its Enterprise version. It would be a killer feature for Gitea to have this.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@lunny
Copy link
Member

lunny commented Feb 18, 2017

I'm not very clear with this feature.

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 18, 2017
@lunny lunny added this to the 2.x.x milestone Feb 18, 2017
@mixedCase
Copy link
Author

@lunny Example for GitLab: https://docs.gitlab.com/ee/workflow/time_tracking.html

@kolaente
Copy link
Member

Or we could simply make a button next to the issue "Start Timetracking" and once you're finished you would just click "Stop Timetracking" and it would save the time spent with the issue. Like you can do it in Flyspray.

With this, you wouldnt need an extra tool for timetracking.

@jonasfranz
Copy link
Member

My Concept:

  1. "Start" button for timetracking starts a sort of stopwatch.
  2. "Stop" button stops the stopwatch and creates a record with the timedifference between the startdate and the stopdate.
  3. The tracked time appeares as a reference in the issue (like commit references)
  4. At the right sidebar appears a listing of the tracked time in total per user.

@lunny
Copy link
Member

lunny commented Jul 24, 2017

A Start button near the Close button. After click Start button and started, Start button will be changed to Finished button. Click Finished button or a commit with close tag both are ok. Simple click Close button will mean give up the issue.

@kolaente
Copy link
Member

I like the idea, but i would propose to move the button also to the right, where the other options are.

@lunny
Copy link
Member

lunny commented Jul 24, 2017

I like the button near the Close so reminder the user to click the finish but not close.

@jonasfranz
Copy link
Member

jonasfranz commented Jul 24, 2017

There is a bounty posted on this issue.
Bountysource

@jonasfranz
Copy link
Member

@lunny I agree with @kolaente because a button at the right sidebar would be more convenient because of the existence of the "Subscribe" button. It could be placed below this button in an equal style with other icons.

Having the button near the close button could point out that the user must write a comment to track his/her time but you rarely write a comment and track the spent time simultaneously.

@jonasfranz
Copy link
Member

I've made a smll UI draft. What do you think?
An alternative according to @lunny will be theire soon.
Time Tracker Finish
Time Tracker Start

@kolaente
Copy link
Member

Colors would be nice, maybe yellow to indicate it's currently tracking.

@lafriks
Copy link
Member

lafriks commented Jul 24, 2017

Also option to enable/disable time tracking for organization/repository/server would be great

@jonasfranz
Copy link
Member

timetracking_new

  • The "+" button let the user add spent time manually by a modal.
  • The "Start" button will start a stopwatch
  • Every time tracking event will be logged in the timeline
  • Under the Start / + button is a list of the total time spent by the users

jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 24, 2017
Adding database models for stopwatches and trackedtimes

See go-gitea#967

Signed-off-by: Jonas Franz <[email protected]>
jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 24, 2017
Adding database models for stopwatches and trackedtimes

See go-gitea#967
+gofmt

Signed-off-by: Jonas Franz <[email protected]>
@lafriks
Copy link
Member

lafriks commented Jul 24, 2017

I think button "Add" will be much clearer than "+"

jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 24, 2017
jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 25, 2017
Make UI functional
Add hints in timeline for time tracking events

See go-gitea#967

Signed-off-by: Jonas Franz <[email protected]>
jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 25, 2017
Adding "Add time manual" option
Improved stopwatch
Created report of total spent time by user

See go-gitea#967

Signed-off-by: Jonas Franz <[email protected]>
jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 25, 2017
jonasfranz added a commit to jonasfranz/gitea that referenced this issue Jul 25, 2017
See go-gitea#967

Signed-off-by: Jonas Franz <[email protected]>
lafriks pushed a commit that referenced this issue Sep 12, 2017
* Added comment's hashtag to url for mail notifications.
* Added explanation to return statement + documentation.
* Replacing in-line link generation with HTMLURL. (+gofmt)
* Replaced action-based model with nil-based model. (+gofmt)
* Replaced mailIssueActionToParticipants with mailIssueCommentToParticipants.
* Updating comment for mailIssueCommentToParticipants
* Added link to comment in "Dashboard"
* Deleting feed entry if a comment is going to be deleted
* Added migration
* Added improved migration to add a CommentID column to action.
* Added improved links to comments in feed entries.
* Fixes #1956 by filtering for deleted comments that are referenced in actions.
* Introducing "IsDeleted" column to action.
* Adding design draft (not functional)
* Adding database models for stopwatches and trackedtimes
* See #967
* Adding design draft (not functional)
* Adding translations and improving design
* Implementing stopwatch (for timetracking)
* Make UI functional
* Add hints in timeline for time tracking events
* Implementing timetracking feature
* Adding "Add time manual" option
* Improved stopwatch
* Created report of total spent time by user
* Only showing total time spent if theire is something to show.
* Adding license headers.
* Improved error handling for "Add Time Manual"
* Adding @sapks 's changes, refactoring
* Adding API for feature tracking
* Adding unit test
* Adding DISABLE/ENABLE option to Repository settings page
* Improving translations
* Applying @sapk 's changes
* Removing repo_unit and using IssuesSetting for disabling/enabling timetracker
* Adding DEFAULT_ENABLE_TIMETRACKER to config, installation and admin menu
* Improving documentation
* Fixing vendor/ folder
* Changing timtracking routes by adding subgroups /times and /times/stopwatch (Proposed by @lafriks )
* Restricting write access to timetracking based on the repo settings (Proposed by @lafriks )
* Fixed minor permissions bug.
* Adding CanUseTimetracker and IsTimetrackerEnabled in ctx.Repo
* Allow assignees and authors to track there time too.
* Fixed some build-time-errors + logical errors.
* Removing unused Get...ByID functions
* Moving IsTimetrackerEnabled from context.Repository to models.Repository
* Adding a seperate file for issue related repo functions
* Adding license headers
* Fixed GetUserByParams return 404
* Moving /users/:username/times to /repos/:username/:reponame/times/:username for security reasons
* Adding /repos/:username/times to get all tracked times of the repo
* Updating sdk-dependency
* Updating swagger.v1.json
* Adding warning if user has already a running stopwatch (auto-timetracker)
* Replacing GetTrackedTimesBy... with GetTrackedTimes(options FindTrackedTimesOptions)
* Changing code.gitea.io/sdk back to code.gitea.io/sdk
* Correcting spelling mistake
* Updating vendor.json
* Changing GET stopwatch/toggle to POST stopwatch/toggle
* Changing GET stopwatch/cancel to POST stopwatch/cancel
* Added migration for stopwatches/timetracking
* Fixed some access bugs for read-only users
* Added default allow only contributors to track time value to config
* Fixed migration by chaging x.Iterate to x.Find
* Resorted imports
* Moved Add Time Manually form to repo_form.go
* Removed "Seconds" field from Add Time Manually
* Resorted imports
* Improved permission checking
* Fixed some bugs
* Added integration test
* gofmt
* Adding integration test by @lafriks
* Added created_unix to comment fixtures
* Using last event instead of a fixed event
* Adding another integration test by @lafriks
* Fixing bug Timetracker enabled causing error 500 at sidebar.tpl
* Fixed a refactoring bug that resulted in hiding "HasUserStopwatch" warning.
* Returning TrackedTime instead of AddTimeOption at AddTime.
* Updating SDK from go-gitea/go-sdk#69
* Resetting Go-SDK back to default repository
* Fixing test-vendor by changing ini back to original repository
* Adding "tags" to swagger spec
* govendor sync
* Removed duplicate
* Formatting templates
* Adding IsTimetrackingEnabled checks to API
* Improving translations / english texts
* Improving documentation
* Updating swagger spec
* Fixing integration test caused be translation-changes
* Removed encoding issues in local_en-US.ini.
* "Added" copyright line
* Moved unit.IssuesConfig().EnableTimetracker into a != nil check
* Removed some other encoding issues in local_en-US.ini
* Improved javascript by checking if data-context exists
* Replaced manual comment creation with CreateComment
* Removed unnecessary code
* Improved error checking
* Small cosmetic changes
* Replaced int>string>duration parsing with int>duration parsing
* Fixed encoding issues
* Removed unused imports

Signed-off-by: Jonas Franz <[email protected]>
@lunny lunny modified the milestones: 2.x.x, 1.3.0 Sep 24, 2017
@Caballerog
Copy link

I'm testing this feature, which I think that is very useful, but should allow the user modify or delete a time tracking event because It can make a mistake. Good job!! :-)

@daviian
Copy link
Member

daviian commented Oct 1, 2017

@Caballerog Please create a new issue for this feature request.

@Caballerog
Copy link

@daviian Thanks ;-) rel #2642

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated/theme/timetracker type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants