-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Show pull icon on pull #10061
[UI] Show pull icon on pull #10061
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10061 +/- ##
=========================================
Coverage ? 42.35%
=========================================
Files ? 618
Lines ? 80774
Branches ? 0
=========================================
Hits ? 34213
Misses ? 42352
Partials ? 4209 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ignore my comment about the unrelated change. make fmt
must have done that (as for why it was accepted without it before, it beats me).
should I send a backport (only templates/repo/issue/view_title.tmpl change) to 1.11.x branch? |
was it previously a pull icon and then it changed or is this a new feature? |
if it's a new feature probably we shouldn't backport |
I would considder this as ui-fix in my opinion |
send a backport then |
Before
After