Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feishu webhook support #10229

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Add feishu webhook support #10229

merged 3 commits into from
Feb 12, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 11, 2020

This PR will add webhook support for feishu(https://feishu.cn).

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 11, 2020
@lunny lunny added this to the 1.12.0 milestone Feb 11, 2020
@lunny lunny force-pushed the lunny/support_feishu branch from b370bf7 to b9e605a Compare February 11, 2020 08:55
@codecov-io
Copy link

codecov-io commented Feb 11, 2020 •
edited
Loading

Codecov Report

Merging #10229 into master will decrease coverage by 0.08%.
The diff coverage is 3.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10229      +/-   ##
==========================================
- Coverage   43.67%   43.58%   -0.09%     
==========================================
  Files         582      583       +1     
  Lines       80047    80263     +216     
==========================================
+ Hits        34961    34986      +25     
- Misses      40751    40945     +194     
+ Partials     4335     4332       -3
Impacted Files Coverage Δ
modules/structs/hook.go 6.66% <ø> (ø) ⬆️
modules/webhook/webhook.go 43.6% <0%> (-1.71%) ⬇️
models/webhook.go 68.7% <0%> (-0.48%) ⬇️
modules/webhook/feishu.go 0% <0%> (ø)
modules/auth/repo_form.go 44.44% <0%> (-0.78%) ⬇️
routers/repo/webhook.go 1.27% <0%> (-0.11%) ⬇️
modules/setting/webhook.go 56.25% <100%> (ø) ⬆️
routers/routes/routes.go 86.57% <100%> (+0.09%) ⬆️
modules/queue/unique_queue_disk_channel.go 52.56% <0%> (-1.93%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7ad38...9523e28. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2020
@6543
Copy link
Member

6543 commented Feb 11, 2020 •
edited
Loading

need update too:

gitea/modules/structs/hook.go

Line 44 in ad2642a

// enum: dingtalk,discord,gitea,gogs,msteams,slack,telegram

6543
6543 reviewed Feb 11, 2020
View reviewed changes
routers/repo/webhook.go Outdated Show resolved Hide resolved
6543
6543 reviewed Feb 11, 2020
View reviewed changes
routers/repo/webhook.go Outdated Show resolved Hide resolved
6543
6543 reviewed Feb 11, 2020
View reviewed changes
modules/auth/repo_form.go Outdated Show resolved Hide resolved
6543
6543 requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you missed to change some things where you copy parts of the code ...

@lunny lunny force-pushed the lunny/support_feishu branch from b9e605a to 9523e28 Compare February 12, 2020 03:46
@lunny
Copy link
Member Author

lunny commented Feb 12, 2020

@6543 @guillep2k done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 12, 2020
@zeripath zeripath merged commit 83a8944 into go-gitea:master Feb 12, 2020
@lunny lunny deleted the lunny/support_feishu branch February 12, 2020 09:22
@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label Feb 12, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @codecov-io @6543 @guillep2k @zeripath @GiteaBot @delvh