-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build gitea1.11 with go1.13 #10584
Build gitea1.11 with go1.13 #10584
Conversation
Go 1.13 instead of? |
It defaults to latest version of XGO, which is currently 1.14 so this PR brings it down to 1.13 support. |
Hmm could you check if an equivalent to #10583 makes building on go 1.14 work? That might be better than forcibly downgrading to 1.13 (although perhaps the archivist in me likes the idea of forcibly saying what this did build on) |
I completely agree. We already do this with our docker builds, and so we should keep same approach with our binary builds too. Your PR will solve one of the issues that 1.14 brings (specifically solves the linked issue), I'll create a patch file that you can apply to your PR that'll catch a few others (that others have yet to run into, but thankfully our tests catch). |
Make lg-tm work |
as title