Replace emojify with unicode emoji #11031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove emojify and replace it with custom name-to-unicode replacement - move tribute code to own file as it depends on emoji data This depends on simplemap.json that emojilib publishes which is a 40kB JSON file containing name-to-unicode mappings. It supports 1571 emoji compared to the previous 881 of emojify. Fixes: go-gitea#9182 Fixes: go-gitea#8974 Fixes: go-gitea#8953
|
👀 did we just write and submit the same pr?!? |
GiteaBot
added
the
lgtm/need 2
|
BTW for anyone wondering why the drometary turned a camel in those screenshots. From the data, which also matches GitHub's behaviour, meaning previous |
|
@mrsdizzie oh damn 🤣 |
|
Let me know if you want to collaborate or what you think -- I kind of like doing it in go better but would love opinions from anybody who has spent time with emojis recently |
|
@mrsdizzie so your approach does it on the backend rendering? I think that's generally the better approach of the two because JS replacement always sucks because of wrong content flashes. I will investigate your PR. |
|
Closing for #11032. Will repurpose some code from here there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on simplemap.json that emojilib publishes which is a 40kB JSON file containing name-to-unicode mappings. It supports 1571 emoji compared to the previous 881 of emojify.
Before:
After:
Fixes: #9182
Fixes: #8974
Fixes: #8953