Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug about comment attachment #11272

Merged
merged 2 commits into from
May 2, 2020
Merged

Fix bug about comment attachment #11272

merged 2 commits into from
May 2, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented May 2, 2020

Fix #11173

@lunny lunny added the type/bug label May 2, 2020
@lunny lunny added this to the 1.12.0 milestone May 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 2, 2020
@lunny lunny mentioned this pull request May 2, 2020
Closed
3 tasks
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2020
@6543
Copy link
Member

6543 commented May 2, 2020

CI failed unrelated & good to have this fixed

@codecov-io
Copy link

Codecov Report

Merging #11272 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11272   +/-   ##
=======================================
  Coverage   43.79%   43.79%           
=======================================
  Files         607      607           
  Lines       86876    86876           
=======================================
+ Hits        38045    38047    +2     
  Misses      44133    44133           
+ Partials     4698     4696    -2
Impacted Files Coverage Δ
modules/indexer/stats/db.go 50.00% <0.00%> (-9.38%) ⬇️
modules/process/manager.go 74.69% <0.00%> (-3.62%) ⬇️
services/pull/patch.go 62.93% <0.00%> (-2.80%) ⬇️
services/pull/temp_repo.go 31.62% <0.00%> (-2.57%) ⬇️
modules/git/repo.go 50.62% <0.00%> (-1.26%) ⬇️
models/issue.go 52.41% <0.00%> (+0.46%) ⬆️
modules/notification/webhook/webhook.go 43.59% <0.00%> (+0.58%) ⬆️
services/pull/check.go 53.04% <0.00%> (+0.60%) ⬆️
services/pull/pull.go 33.96% <0.00%> (+0.76%) ⬆️
modules/git/command.go 89.56% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f8308...6583d93. Read the comment docs.

@zeripath zeripath merged commit 71e4c75 into go-gitea:master May 2, 2020
@lunny lunny deleted the lunny/fix_attach branch May 2, 2020 15:31
@guillep2k guillep2k added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 3, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@lunny
Fix bug about comment attachment (go-gitea#11272)
8a282b3
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Attachments in different comments become overwritten
7 participants
@lunny @6543 @codecov-io @techknowlogick @zeripath @guillep2k @GiteaBot