Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "only mail on mention" bug #12775

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Fix "only mail on mention" bug #12775

merged 3 commits into from
Sep 9, 2020

Conversation

a1012112796
Copy link
Member

fix #12774

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #12775 into master will decrease coverage by 0.01%.
The diff coverage is 49.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12775      +/-   ##
==========================================
- Coverage   43.26%   43.25%   -0.02%     
==========================================
  Files         649      650       +1     
  Lines       72046    72048       +2     
==========================================
- Hits        31169    31162       -7     
- Misses      35838    35843       +5     
- Partials     5039     5043       +4
Impacted Files Coverage Δ
routers/repo/repo.go 28.46% <ø> (-4.26%) ⬇️
routers/repo/view.go 38.11% <ø> (ø)
routers/repo/migrate.go 44.82% <44.82%> (ø)
models/user.go 53.87% <100.00%> (+0.31%) ⬆️
modules/structs/repo.go 50.00% <100.00%> (-15.52%) ⬇️
services/mailer/mail_issue.go 57.83% <100.00%> (ø)
services/mailer/mail_release.go 80.64% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd49aa...5852348. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 9, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 9, 2020
@techknowlogick techknowlogick changed the title fix mail mention bug Fix "only mail on mention" bug Sep 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 9, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 9, 2020
@techknowlogick techknowlogick merged commit ffa12bd into go-gitea:master Sep 9, 2020
@lunny
Copy link
Member

lunny commented Sep 10, 2020

Please send backport to v1.12

a1012112796 added a commit to a1012112796/gitea that referenced this pull request Sep 10, 2020
@a1012112796 @techknowlogick
Fix "only mail on mention" bug (go-gitea#12775)
c27cc1a 
* fix mail mention bug

fix go-gitea#12774

Signed-off-by: a1012112796 <[email protected]>

* fix test

Co-authored-by: techknowlogick <[email protected]>
@a1012112796 a1012112796 deleted the fix_mention branch September 10, 2020 05:13
@a1012112796 a1012112796 mentioned this pull request Sep 10, 2020
Merged
lafriks pushed a commit that referenced this pull request Sep 10, 2020
@a1012112796 @techknowlogick
Fix "only mail on mention" bug (#12775) (#12789)
0ee823b 
* fix mail mention bug

fix #12774

Signed-off-by: a1012112796 <[email protected]>

* fix test

Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@zeripath zeripath added the backport/done All backports for this PR have been created label Sep 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

"Only Email on Mention" settings is broken
7 participants
@a1012112796 @codecov-commenter @lunny @zeripath @6543 @techknowlogick @GiteaBot