Include OriginalAuthor in Reaction constraint #13505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating repositories with reactions with deleted users, the original author id may be -1. This means that it is possible to end up attempting to create multiple reactions with the same [ Type, IssueID, CommentID, UserID, OriginalAuthorID ] thus breaking the constraints. On SQLite this appears to cause a deadlock but on other dbs this will cause the migration to fail. This PR extends the constraint to include the original author username in the constraint. Fix go-gitea#13271 Signed-off-by: Andrew Thornton <[email protected]>
|
ok migration cant be backported ... I'll file a pull to drop entrys from API witch wont have any chance to get migrated to an existing user somehow |
GiteaBot
added
the
lgtm/need 2
|
The backport would just have to drop the reactions if they have originalauthorid -1 I think |
|
admittedly such a backport would not be a backport just an alternate fix but it's the only solution. |
6543
approved these changes
Nov 10, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Nov 10, 2020
GiteaBot
added
lgtm/done
Signed-off-by: Andrew Thornton <[email protected]>
…' of github.com:zeripath/gitea into fix-13271-move-original-author-into-reaction-constraint
|
damn recreateTable has to be in a transaction for MSSQL - just put it in one |
Codecov Report
@@ Coverage Diff @@
## master #13505 +/- ##
==========================================
- Coverage 42.21% 42.16% -0.06%
==========================================
Files 694 695 +1
Lines 76351 76368 +17
==========================================
- Hits 32231 32199 -32
- Misses 38848 38886 +38
- Partials 5272 5283 +11
Continue to review full report at Codecov.
|
zeripath
deleted the
fix-13271-move-original-author-into-reaction-constraint
branch
6 tasks
6 tasks
|
potential issue from this -> #13588 |
|
No this is not the cause of your issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating repositories with reactions with deleted users, the original
author id may be -1. This means that it is possible to end up attempting
to create multiple reactions with the same [ Type, IssueID, CommentID, UserID,
OriginalAuthorID ] thus breaking the constraints.
On SQLite this appears to cause a deadlock but on other dbs this will
cause the migration to fail.
This PR extends the constraint to include the original author username
in the constraint.
Fix #13271
Signed-off-by: Andrew Thornton [email protected]