Add ui.explore settings to control view of explore pages #13687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `[ui.explore]` settings to allow restricting the explore pages to logged in users only and to restrict the showing of users to only those with publically available repositories. The two proposed settings are: - `REQUIRE_SIGNIN_VIEW`: Only allows access to the explore pages if the user is signed in. Also restricts `/api/v1/user/search`. - `ONLY_SHOW_USERS_WITH_PUBLIC_REPOS`: Only shows users with public repos on the explore page. `/api/v1/user/search` will only show users with public repos unless the user the is signed in. Fix go-gitea#2908 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
the
type/feature
|
This is likely to need further thought and we should think about the api calls for repositories too. |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: a1012112796 <[email protected]>
chinese translation
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
Imho we don't need special app.ini settings for this. My proposal would be:
|
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #13687 +/- ##
==========================================
- Coverage 42.27% 42.24% -0.04%
==========================================
Files 697 698 +1
Lines 76616 76695 +79
==========================================
+ Hits 32389 32396 +7
- Misses 38908 38971 +63
- Partials 5319 5328 +9
Continue to review full report at Codecov.
|
|
I think there's still likely to be a point for findability for public repositories and users with public repos. |
|
I would guess however that we should default to only showing users with public repositories |
|
There is not much point in listing users with public repositories, it will be resource intensive imho and usually everyone are still using repository listing |
|
Please resolve the conflicts |
Signed-off-by: Andrew Thornton <[email protected]>
|
Conflicts fixed |
Signed-off-by: Andrew Thornton <[email protected]>
|
conflicts fixed again |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this pull request
Mar 11, 2021
This is an alternative PR to #13687. Add `[ui.explore]` settings to allow restricting the explore pages to logged in users only and to disable the users explore page. The two proposed settings are: - `REQUIRE_SIGNIN_VIEW`: Only allows access to the explore pages if the user is signed in. Also restricts - `/api/v1/user/search` - `/api/v1/users/{username}` - `/api/v1/users/{username}/repos` - but does not restrict `/api/v1/users/{username}/heatmap` - `DISABLE_USERS_PAGE`: Disables the /explore/users page Fix #2908 Close #13687 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
[ui.explore]settings to allow restricting theexplore pages to logged in users only and to restrict
the showing of users to only those with publically available
repositories.
The two proposed settings are:
REQUIRE_SIGNIN_VIEW: Only allows access to the explore pages if theuser is signed in. Also restricts
/api/v1/user/search/api/v1/users/{username}/api/v1/users/{username}/repos/api/v1/users/{username}/heatmapONLY_SHOW_USERS_WITH_PUBLIC_REPOS: Only shows users with publicrepos on the explore page.
/api/v1/user/searchwill only show userswith public repos unless the user the is signed in.
Fix #2908
Close #14094
Signed-off-by: Andrew Thornton [email protected]