Fix review request notification email links when external issue tracker is enabled #13723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Nov 27, 2020
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #13723 +/- ##
==========================================
- Coverage 42.19% 42.18% -0.01%
==========================================
Files 697 697
Lines 76825 76825
==========================================
- Hits 32418 32412 -6
- Misses 39059 39064 +5
- Partials 5348 5349 +1
Continue to review full report at Codecov.
|
|
I think this could be fixed to pass the fact that we know it is a PR in the metas so we aren't sending users the weird ! workaround (since we know it is a PR already and that is just for the case when a user is typing and we can't possibly know if they mean an issue or PR by just a number). |
mrsdizzie
reviewed
Nov 27, 2020
…r is enabled The issue.HTMLURL() automatically gets converted to the expected #issue format by the post processors
jpraet
force-pushed
the
13720-review-request-notification-issue
branch
from
84a6498 to
22ba810
Compare
lafriks
approved these changes
Nov 28, 2020
GiteaBot
added
lgtm/done
lafriks
added
type/bug
and removed
topic/ui
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13720
Use !%d issue notation instead of #%d in review request notification when external issue tracker is enabled.
Or would it be preferrable to just always use the !%d notation here?
I noticed in other places like the default squash commit messages the choice between ! and # is also done based on whether external issue tracker is enabled. So I did it here as well.