-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify settings pages with item list #1389
Conversation
I have gone a little further in little cleaning. In some case there we're item with grid with only one column and other with a "useless" column (the point) for indicating activity when it could be display in icon. Note : I don't know why lessc add !important and simplify color #bbb it also does it on master branch ... |
Why not keeping the About |
Please also check if we need to update the templates version (I'm pretty sure Gogs had the concept of a "template version" to make sure templates and code reading them would be consistent, not sure if that concept is still working in Gitea) |
@strk I have use a icon from semantic because it need the class .icon to be well display in .item but the class .icon override .octicon-* classes so I will need add some "hack" to fix it. If we want to keep octicon icon. |
Looking at it should be only add |
f5d1420
to
90aba36
Compare
90aba36
to
1359d18
Compare
LGTM |
LGTM |
@sapk Why you delete ".key" class from less file? I am working (testing) on patch to fix multiple broken pages after your commit and this one missing word is problem. You changed styling in whole "settings" scope. Can i revert this little change? |
This PR simplify the html and remove some specific css "hack" with a more generic and global css for all items lists. |
In fact the .key is not completely removed but only the .key.meta specific code is kept for color and better spacing between line. |
Looking at your issue, I will have a look if it doesn't have impacted others pages |
@sapk It has impact also on dropdown options (repo ->collaborators -> user rights). If i revert ".key" in less file it looks OK and your change should still work fine (tested booth shh key settings). |
Make a PR because I don't see exactly what you mean. I will force me to take time to propose a quick solution or look at your PR soon. |
Gitea SSH key seeting page display a column with a point indicating if the key is used recently.
It's more simple to display recent use of key like github and color the key icon and date of recent use.
Before :
After :
Still need to be apply in repository key list.