Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise logging of failed authentication attempts in internal SSH #13962

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

zeripath
Copy link
Contributor

Continuing on from #13953 continue to improve and standardise
logging from internal SSH.

Also updates the fail2ban setup

Signed-off-by: Andrew Thornton [email protected]

Continuing on from go-gitea#13953 continue to improve and standardise
logging from internal SSH.

Also updates the fail2ban setup

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality labels Dec 12, 2020
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #13962 (701fbbd) into master (1837e64) will decrease coverage by 0.12%.
The diff coverage is 32.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13962      +/-   ##
==========================================
- Coverage   42.25%   42.12%   -0.13%     
==========================================
  Files         710      710              
  Lines       77226    77250      +24     
==========================================
- Hits        32628    32541      -87     
- Misses      39235    39359     +124     
+ Partials     5363     5350      -13     
Impacted Files Coverage Δ
modules/ssh/ssh.go 43.19% <32.14%> (-1.03%) ⬇️
modules/notification/ui/ui.go 84.72% <0.00%> (-11.12%) ⬇️
models/issue_comment.go 45.46% <0.00%> (-7.26%) ⬇️
modules/notification/mail/mail.go 33.33% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 49.67% <0.00%> (-3.95%) ⬇️
modules/notification/base/null.go 74.28% <0.00%> (-2.86%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/notification/notification.go 83.92% <0.00%> (-2.68%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-2.25%) ⬇️
services/gitdiff/gitdiff.go 69.05% <0.00%> (-1.94%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1837e64...701fbbd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 12, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 12, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2020
@zeripath zeripath merged commit 980b0df into go-gitea:master Dec 15, 2020
@zeripath zeripath deleted the report-permission-denied-in-ssh-2 branch December 15, 2020 08:45
@zeripath zeripath added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Dec 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants