-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webhook list styling #14001
Fix webhook list styling #14001
Conversation
Small patch to pull in to fix margin on the red/yellow icons: diff --git a/templates/repo/settings/webhook/list.tmpl b/templates/repo/settings/webhook/list.tmpl
index f39f632a9..02a3bcad6 100644
--- a/templates/repo/settings/webhook/list.tmpl
+++ b/templates/repo/settings/webhook/list.tmpl
@@ -43,11 +43,11 @@
</div>
{{range .Webhooks}}
<div class="item">
{{if eq .LastStatus 1}}
- <span class="text green">{{svg "octicon-check"}}</span>
+ <span class="text green mr-3">{{svg "octicon-check"}}</span>
{{else if eq .LastStatus 2}}
- <span class="text red">{{svg "octicon-alert"}}</span>
+ <span class="text red mr-3">{{svg "octicon-alert"}}</span>
{{else}}
<span class="text grey mr-3">{{svg "octicon-dot-fill"}}</span>
{{end}}
<a class="dont-break-out" href="{{$.BaseLink}}/{{.ID}}">{{.URL}}</a> Before: After: |
@@ -1,4 +1,14 @@ | |||
.admin { | |||
&.hooks .list { | |||
> .item { | |||
&:not(:first-child) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also .item + .item
for a more robust selector.
Codecov Report
@@ Coverage Diff @@
## master #14001 +/- ##
==========================================
+ Coverage 42.20% 42.22% +0.02%
==========================================
Files 710 710
Lines 77273 77281 +8
==========================================
+ Hits 32612 32632 +20
+ Misses 39288 39278 -10
+ Partials 5373 5371 -2
Continue to review full report at Codecov.
|
#13860 tried to fix webhook list styling on admin dashboard, but in turn it broke for repository settings.
Before:
After: