Dropdown triangle fixes #14028
Merged
Dropdown triangle fixes #14028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fomantic's CSS assumes the dropdown triangles are fonts but we've recently swapped them for SVG so we need to wrestle a bit with Fomantic to get it to display properly and not cause buttons to resize. Fixes: go-gitea#14014
zeripath
approved these changes
Dec 16, 2020
GiteaBot
added
the
lgtm/need 1
|
CI failure is unrelated. |
6543
approved these changes
Dec 17, 2020
GiteaBot
added
lgtm/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 17, 2020
go-gitea#14028 had improved dropdown triangle display for buttons with text but had regressed it for buttons without. Fix this by adding a class to prevent horizontal margin adjustment.
techknowlogick
added a commit
that referenced
this pull request
Dec 19, 2020
#14028 had improved dropdown triangle display for buttons with text but had regressed it for buttons without. Fix this by adding a class to prevent horizontal margin adjustment. Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fomantic's CSS assumes the dropdown triangles are fonts but we've recently swapped them for SVG so we need to wrestle a bit with Fomantic to get it to display properly and not cause buttons to resize.
Fixes: #14014